-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data source: azurerm_network_service_tags #6229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍
azurerm/internal/services/compute/tests/resource_arm_managed_disk_test.go
Outdated
Show resolved
Hide resolved
@magodo i changed everything accordingly. Any problems left? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR @r0bnet, I have some questions about the filter attribute and regional/global tags that can be found in the comments i've left inline. Additionaly there is some minor code changes i'd like to see. Thanks!
azurerm/internal/services/network/data_source_network_service_tags.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/data_source_network_service_tags.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/data_source_network_service_tags.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/data_source_network_service_tags.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/data_source_network_service_tags.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/data_source_network_service_tags.go
Outdated
Show resolved
Hide resolved
# Conflicts: # azurerm/internal/services/compute/tests/resource_arm_managed_disk_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @r0bnet, looks good now aside from we still need to nil check region before dereferencing. Hope you don't mind but i'm going to push that change myself to get this merged!
@katbyte all good, i'm fine with you pushing changes. But don't know why the tests are failing. I ran them locally with no error. I just merged master so see if those were temp issues. |
This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.3.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Service Tags / address prefixes are useful when using firewall rules or UDRs in some scenarios.